git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] diffcore-rename: Remove unused variable 'num_src'

From
IMIngo Molnar <mingo@elte.hu>
Date
Apr 29, 2011, 06:35 UTC
Message-ID
<20110429063506.GA13893@elte.hu>
GCC 4.6 noticed an initialized but unused variable in diffcore_rename():
  diffcore-rename.c: In function ‘diffcore_rename’:
  diffcore-rename.c:501:18: warning: variable ‘num_src’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
diff --git a/diffcore-rename.c b/diffcore-rename.c
index d0259be..f639601 100644
--- a/diffcore-rename.c
+++ b/diffcore-rename.c
@@ -498,7 +498,7 @@ void diffcore_rename(struct diff_options *options)
 	struct diff_queue_struct outq;
 	struct diff_score *mx;
 	int i, j, rename_count, skip_unmodified = 0;
-	int num_create, num_src, dst_cnt;
+	int num_create, dst_cnt;
 	struct progress *progress = NULL;
 
 	if (!minimum_score)
@@ -554,7 +554,6 @@ void diffcore_rename(struct diff_options *options)
 	 * files still remain as options for rename/copies!)
 	 */
 	num_create = (rename_dst_nr - rename_count);
-	num_src = rename_src_nr;
 
 	/* All done? */
 	if (!num_create)
Message 1 of 1 in “diffcore-rename: Remove unused variable 'num_src'”
  1. diffcore-rename: Remove unused variable 'num_src'Ingo Molnar, Apr 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.