Re: [PATCH] git-svn: Add a svn-remote.<name>.pushurl config key

From: Jeff King <peff@peff.net>
Date: Apr 22, 2011, 19:36 UTC
Message-ID: <20110422193621.GB3323@sigill.intra.peff.net>
In-Reply-To: <4DB1D2F2.6040000@mit.edu>

On Fri, Apr 22, 2011 at 03:11:46PM -0400, "Alejandro R. Sedeño" wrote:

> I'd be happy to see something like this get in. I've often noticed
> git-send-email telling me that it couldn't parse an address out of my
> signed-of-by lines, but I never stopped and took the time to look into it.

That is a separate issue. The patch I posted will make format-patch properly quote rfc822 specials in actual email header lines. But Signed-off-by lines will remain as they are, being part of the message body. And I think that's what we want. You certainly wouldn't want to rfc2047-encode them (they are already covered by the body's content-type encoding).

And while you could quote rfc822 specials, people don't tend to do that. There's no formal syntax defined, but people tend to treat them as:

  Signed-off-by: (.*) <(.*)>

i.e., everything inside <> is an address, and everything before that is the name.

If there is an issue with send-email parsing signed-off-by lines or formatting the addresses it pulls from them, that's a separate problem that will need to be dealt with in send-email.

-Peff