Re: [PATCH] contrib/completion: remove parentheses from prompt

From: Kim Phillips <kim.phillips@freescale.com>
Date: Apr 22, 2011, 23:43 UTC
Message-ID: <20110422184334.98ce52a6.kim.phillips@freescale.com>
In-Reply-To: <7vk4elnchw.fsf@alter.siamese.dyndns.org>

On Fri, 22 Apr 2011 15:32:27 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

> Kim Phillips <kim.phillips@freescale.com> writes:
> 
> > Save horizontal terminal line real estate by removing parentheses from
> > the prompt branch display.  The branch is already sufficiently visually
> > delimited by the preceding space character.
> 
> That changes behaviour and makes people who like the current output
> unhappy, no?  For example, I have
> 
> 	PS1=': \h \W$(__git_ps1 "/%s"); '
> 
> and from it I get these output:
> 
> 	: host git.git/master;
> 	: host git.git/(v1.7.5-rc3);
>         : host git.git/(63e4ee5...);
> 
> I do like the fact that the tagname v1.7.5-rc3 is parenthesized---it makes
> it very clear that I am not on any branch while being detached.
> 
> Of course that is _my_ personal taste, but I wonder if you can remove the
> parentheses by changing the way you use __git_ps1 in your PS1 definition.

Oh I see what happened. A long time ago I had changed the recommended PS1 from the top of git-completion.bash to a version without the parentheses, but I must've started working in detached states more recently until finally _my_ personal distaste for parens kicked in again.

Fwiw, especially on properly managed projects, the content of the name itself is enough to distinguish a branch name from a tag name (which usually contains a version value), from a raw sha followed by three dots. But I'd understand if people want it to be more deterministic.

Thanks,

Kim