Re: [WRONG/PATCH 1/3] revisions: clarify handling of --no-walk and --do-walk

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 21, 2011, 21:30 UTC
Message-ID: <20110421213014.GB18418@elie>
In-Reply-To: <4DB02B24.4030503@drmicha.warpmail.net>

Michael J Gruber wrote:

> This is not unrelated to the tip of gitster/mg/show-without-prune, i.e.
>
> 0c738b6 (builtin/show: do not prune by pathspec, 2011-04-01)

True.

> We should rethink the ui balance between deviating from the usual log
> option processing and the usefulness here.

Could you expand on that? I think --no-walk being a positional argument is just an ugly consequence of the code that permits

	git show -5 master
	git show maint..
	git show --do-walk master

while making sure

	git show master
	git show --do-walk --no-walk master

still show only one commit. I'm not convinced it's meant to be useful beyond that.

(Maybe "git log --no-walk maint..HEAD" should be an error because meaningless, while "git rev-list --no-walk maint..HEAD" should be accepted so people can continue write their own "git show"-like commands. Unfortunately the popular idiom of using git log --format=... instead of

	git rev-list ... |
	git diff-tree -s --format=... --stdin

in scripts makes this porcelain-plumbing distinction more fuzzy than I would like.)