[PATCH v2 0/2] Re: run-command: write full error message in die_child

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 20, 2011, 10:33 UTC
Message-ID: <20110420103319.GA6027@elie>
In-Reply-To: <4DAE8E66.5060705@viscovery.net>

Johannes Sixt wrote:

> Unfortunately, on Windows, the bash spawnd by git converts LF to CRLF...

[...]

> ... therefore, we fail here. Can we have this squashed in, because 'cat'
> leaves LFs alone?

Thanks for catching this...

[...]

> I did not check whether
> SANITY is really needed; I trust you did.

... and this.  No, SANITY is not needed.

Here's a reroll, on top of v1.7.5-rc3~2 (Revert "run-command: prettify -D_FORTIFY_SOURCE workaround", 2011-04-18). It even applies on maint this way (not that anyone would need that :)).

Jonathan Nieder (2):
  tests: check error message from run_command
  run-command: handle short writes and EINTR in die_child

 run-command.c          |   15 +++++++++------
 t/t0061-run-command.sh |   23 +++++++++++++++++++++++
 test-run-command.c     |    2 ++
 3 files changed, 34 insertions(+), 6 deletions(-)