Re: [BUG] format-patch does not wrap From-field after author name

From: Jeff King <peff@peff.net>
Date: Apr 14, 2011, 17:52 UTC
Message-ID: <20110414175212.GB23342@sigill.intra.peff.net>
In-Reply-To: <BANLkTimruwojkq_HNMZeCDBV6K8_aFc_XQ@mail.gmail.com>

On Thu, Apr 14, 2011 at 07:01:41PM +0200, Erik Faye-Lund wrote:

Show 6 quoted lines

> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 9c66367..a4b8b59 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -793,4 +793,19 @@ test_expect_success 'format-patch wraps extremely
> long headers (rfc2047)' '

Speaking of wrapping, your MUA seems to have mangled the patch.

Show 6 quoted lines

> +M8="foo_bar_"
> +M64=$M8$M8$M8$M8$M8$M8$M8$M8
> +cat >expect <<'EOF'
> +From: foo_bar_foo_bar_foo_bar_foo_bar_foo_bar_foo_bar_foo_bar_foo_bar
> + <foobar@foo.bar>
> +EOF

Your expect data is missing the trailing "_". You could probably just do:

  cat >expect <<EOF
  From: $M64
   <foobar@foo.bar>
  EOF

which is even simpler.

-Peff