Re: [PATCH] supply '-n' to gzip to produce identical tarballs
On Mon, Apr 11, 2011 at 12:24:05PM -0700, Junio C Hamano wrote:
Show 23 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
>
> >> > Perhaps it would be more clear to use
> >> >
> >> > + 'compressor' => ['gzip', '--no-name']},
> >
> >> Definitely, if the argument is the same (or even present) on all systems.
> >> On FreeBSD and GNU both '-n' and '--no-name' are do the job, but an audit
> >> of other systems should be done to ensure they don't break. I chose '-n'
> >> as it seemed the more conservative choice.
> >
> > So you choose '-n' because it has more chance of being widely supported,
> > isn't it? Good enough for me.
>
> Interesting. "gzip <COPYING" does get a consistent result because it can
> fstat to get the timestamp, but "cat COPYING | gzip" does change its
> output every time it is run. Good catch and a solution. Thanks, both.
>
> So I should expect a pull request sometime after 1.7.5 final from you,
> with "an audit of other systems" done by others on the list noted in the
> final commit message?
>
>
Sure, no problem.
Thanks,
Fraser