Re: [PATCH/RFC 10/11] gitweb.js: Add UI for selecting common timezone to display dates

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 10, 2011, 15:10 UTC
Message-ID: <201104101710.44685.jnareb@gmail.com>
In-Reply-To: <1302389366-21515-11-git-send-email-jnareb@gmail.com>

Jakub Narebski wrote:

> KNOWN BUGS:
> ===========

Show 7 quoted lines

> * Replacing inline style for 'popup' and 'close-button' elements of
>   timezone menu with style defined in gitweb.css results in menu being
>   put between datetime and its local part, as if absolute positioning
>   didn't remove element from the flow.
> 
>   Currently style is duplicated in gitweb.css (in CSS file) and in
>   <element>.style.cssText (in JavaScript).

I'm very sorry, false alarm. The error was mine: the CSS in gitweb.css is incorrect; I forgot that in CSS you have only C-like "/* foo */" comments, and C++ / JavaScript-like "// ... \n" doesn't work.

See e.g.: http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Frepo.or.cz%2Fw%2Fgit%2Fjnareb-git.git%2Fblob_plain%2F524656258696381f9e6b9169256688165e21a3f9%3A%2Fgitweb%2Fstatic%2Fgitweb.css&lang=en&profile=css21&usermedium=all&warning=1

Will fix.

Show 11 quoted lines

> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index 79d7eeb..6d17e12 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -579,6 +579,31 @@ div.remote {
>  	display: inline-block;
>  }
>  
> +/* JavaScript-base timezone manipulation */
> +
> +.popup { // timezone selection UI

^^

Should be

  +.popup { /* timezone selection UI */

Show 5 quoted lines

> +	position: absolute;
> +	top: 0; right: 0;
> +	border: 1px solid;
> +	background-color: #f0f0f0;
> +}

-- 
Jakub Narebski
Poland