Re: [tig PATCH] blame broken in recent master

From: Jeff King <peff@peff.net>
Date: Apr 9, 2011, 19:00 UTC
Message-ID: <20110409190018.GA31579@sigill.intra.peff.net>
In-Reply-To: <BANLkTinJm4Zp18D_M=TTLSDr6jBLcPB9RQ@mail.gmail.com>

On Sat, Apr 09, 2011 at 02:37:38PM -0400, Jonas Fonseca wrote:

Show 15 quoted lines

> On Wed, Mar 30, 2011 at 10:24, Jeff King <peff@peff.net> wrote:
> 
> > As of 730ae86 (Rename prepare_io to prepare_update and make it more
> > specialized, 2011-03-16), "tig blame" finds no actual blamed commits.
> >
> > The problem seems to be that prepare_update switched from calling
> > format_argv to argv_copy, and we end up calling "git blame %(blameargs)"
> > without "%(blameargs)" expanded. Blame looks like the only caller which
> > actually uses a placeholder, so it is the only one broken.
> >
> > The patch below fixes it for me, but it seems like a hack. I'm not
> > really sure why the switch in prepare_update was made; clearly it is
> > part of some refactoring, but I'm not sure what your larger plans were.
> 
> I have fixed the issue in the current master.

Thanks, works perfectly here.

-Peff