Re: "prune" prone to clock skew (Re: t3306 failure with v1.7.5-rc1)
- From
Jeff King <peff@peff.net>
- Date
- Apr 8, 2011, 18:53 UTC
- Message-ID
- <20110408185325.GA6337@sigill.intra.peff.net>
- In-Reply-To
- <7vei5c4lwh.fsf@alter.siamese.dyndns.org>
On Fri, Apr 08, 2011 at 11:51:10AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> I don't personally think this is worth addressing, but as I was Cc'ed, > I'll try. > > If we at least know that the object store is contained within a single > filesystem whose clock is at least guaranteed to monotonically increase, > one possible workaround would be to touch a garbage file and read its > timestamp, instead of grabbing the current time from the local clock, no?
Yeah, that is a much more accurate and simpler fix. Like you, I don't really think it's worth worrying about, but if somebody wanted to, that is much better than the fix I mentioned.
-Peff