Re: [PATCH] git.el: Don't use font-lock-compile-keywords

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 3, 2011, 19:25 UTC
Message-ID: <20110403192515.GF3830@elie>
In-Reply-To: <87ei5j2prc.fsf@wine.dyndns.org>

Alexandre Julliard wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

>>> So here it is
>>> again.  The originally proposed patch from Debian is to use
>>> font-lock-add-keywords rather than font-lock-compile-keywords.
>>> However, it doesn't exist in XEmacs, if one is looking to
>>> maintain compatibility, I believe this patch is the right thing
>>> to do.
>>>
>>>  contrib/emacs/git.el |   13 ++++++++++---
>>>  1 files changed, 10 insertions(+), 3 deletions(-)
>>
>> Leaving patch unsnipped for reviewers' sake.
>
> Looks good to me.

Just cc-ing Junio so he can see your ack.

Junio, the patch up-thread fixes a bug reported by Kevin Ryde <user42@zip.com.au>. I'm not knowledgeable enough to see what the impact is, but the emacs experts seem to like it.