git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] strbuf: Introduce strbuf_fwrite corresponding to strbuf_fread

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 31, 2011, 02:15 UTC
Message-ID
<20110331021451.GA31090@elie>
In-Reply-To
<1301422392-21177-4-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> [Subject: strbuf: Introduce strbuf_fwrite corresponding to strbuf_fread]
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>

And why? FWIW strbuf_fread takes care of (1) setting the size of sb to accomodate the input, (2) starting reading at the end of the current strbuf, and (3) freeing the buffer if nothing could be read, so symmetry doesn't seem like a strong justification.

Which is not to say this is a bad change. Just that it's hard to see how it lives up to its goals without knowing what those goals are.

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 6 of 9 in “Towards a Git to SVN bridge”
  1. 0/5 Towards a Git to SVN bridgeRamkumar Ramachandra, Mar 29, 2011
  2. 1/5 date: Expose the time_to_tm functionRamkumar Ramachandra, Mar 29, 2011
  3. 2/5 fast-export: Introduce --inline-blobsRamkumar Ramachandra, Mar 29, 2011
  4. Jonathan NiederMar 29, 2011
  5. 3/5 strbuf: Introduce strbuf_fwrite corresponding to strbuf_freadRamkumar Ramachandra, Mar 29, 2011
  6. Jonathan NiederMar 31, 2011
  7. 4/5 vcs-svn: Introduce svnload, a dumpfile producerRamkumar Ramachandra, Mar 29, 2011
  8. 5/5 t9012-svn-fi: Add tests for svn-fiRamkumar Ramachandra, Mar 29, 2011
  9. Jonathan NiederMar 31, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.