git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PULL svn-fe] Re: Portability: returning void

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 30, 2011, 04:41 UTC
Message-ID
<20110330044116.GB2793@elie>
In-Reply-To
<20110330033017.GA18157@sigill.intra.peff.net>
Jeff King wrote:
> After thinking on it more, I figured out an elegant fix.
All right, thanks again for this.

I really do want to address your "while at it". I'm pretty uncomfortable with the "sleep 100" --- it might be better to do "exec perl -e sleep" so there is no chance that some incredibly slow system won't make the race. Or a failure mode that does not involve a long hang would be even better.

Anyway, to make others' life better quickly I've pushed out the easy part of your fix. It sits with the fixes to other embarrasing bugs.

  git://repo.or.cz/git/jrn.git svn-fe
Jeff King (1):
      tests: kill backgrounded processes more robustly
Jonathan Nieder (2):
      vcs-svn: add missing cast to printf argument
      tests: make sure input to sed is newline terminated
Michael Witten (1):
      vcs-svn: a void function shouldn't try to return something
 t/t0081-line-buffer.sh |   12 ++++++------
 t/t9010-svn-fe.sh      |    8 ++++++--
 vcs-svn/fast_export.c  |    3 ++-
 vcs-svn/svndump.c      |    3 ++-
 4 files changed, 16 insertions(+), 10 deletions(-)
Previous: Jonathan NiederNext: Junio C Hamano
Message 16 of 18 in “Portability: returning void”
  1. Portability: returning voidMichael Witten, Mar 29, 2011
  2. Jonathan NiederMar 29, 2011
  3. Jeff KingMar 29, 2011
  4. Jeff KingMar 29, 2011
  5. Jonathan NiederMar 29, 2011
  6. Jeff KingMar 30, 2011
  7. Jonathan NiederMar 30, 2011
  8. Jeff KingMar 30, 2011
  9. Jonathan NiederMar 30, 2011
  10. Jeff KingMar 30, 2011
  11. Johannes SixtMar 30, 2011
  12. tests: introduce helper to fill a pipe in the backgroundJonathan Nieder, Mar 30, 2011
  13. Jonathan NiederMar 30, 2011
  14. Jeff KingMar 30, 2011
  15. Jonathan NiederMar 30, 2011
  16. [PULL svn-fe] Re: Portability: returning voidJonathan Nieder, Mar 30, 2011
  17. Junio C HamanoMar 30, 2011
  18. Jonathan NiederMar 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.