[PULL svn-fe] Re: Portability: returning void
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 30, 2011, 04:41 UTC
- Message-ID
- <20110330044116.GB2793@elie>
- In-Reply-To
- <20110330033017.GA18157@sigill.intra.peff.net>
Jeff King wrote:
> After thinking on it more, I figured out an elegant fix.
All right, thanks again for this.
I really do want to address your "while at it". I'm pretty uncomfortable with the "sleep 100" --- it might be better to do "exec perl -e sleep" so there is no chance that some incredibly slow system won't make the race. Or a failure mode that does not involve a long hang would be even better.
Anyway, to make others' life better quickly I've pushed out the easy part of your fix. It sits with the fixes to other embarrasing bugs.
git://repo.or.cz/git/jrn.git svn-fe
Jeff King (1):
tests: kill backgrounded processes more robustlyJonathan Nieder (2):
vcs-svn: add missing cast to printf argument
tests: make sure input to sed is newline terminatedMichael Witten (1):
vcs-svn: a void function shouldn't try to return somethingt/t0081-line-buffer.sh | 12 ++++++------ t/t9010-svn-fe.sh | 8 ++++++-- vcs-svn/fast_export.c | 3 ++- vcs-svn/svndump.c | 3 ++- 4 files changed, 16 insertions(+), 10 deletions(-)