Minor cosmetic defect in git-pack-objects output
- From
Antonio Ospite <ospite@studenti.unina.it>
- Date
- Mar 29, 2011, 10:10 UTC
- Message-ID
- <20110329121040.de22bd56.ospite@studenti.unina.it>
Hi,
in some cases, on git-pack-objects failure, there is a small defect in the output, see:
# git gc --aggressive Counting objects: 1954118, done. Delta compression using up to 2 threads. warning: suboptimal pack - out of memory02) Compressing objects: 100% (1936802/1936802), done. Writing objects: 100% (1954118/1954118), done. Total 1954118 (delta 1618716), reused 0 (delta 0)
The defect is here:
warning: suboptimal pack - out of memory02)
^^^
the trailing chars are from the replaced line which was ending in
1936802)AFAICS this is basically what is happening:
#include "git-compat-util.h"
fprintf(stderr, "Compressing objects: 15% (296661/1936802)\r");
warning("suboptimal pack - out of memory");I can think to a dumb workaround for this particular path but maybe there are other places when this can happen as well.
Anyway it is not a big deal, but since I noticed it I wanted to report that.
Regards, Antonio
-- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?