git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH -1/3 (amend)] gitweb: Always call parse_date with timezone parameter

From
Jakub Narebski <jnareb@gmail.com>
Date
Mar 19, 2011, 22:53 UTC
Message-ID
<201103192353.56841.jnareb@gmail.com>
In-Reply-To
<201103192318.45925.jnareb@gmail.com>

Timezone is required to correctly set local time, which would be needed for future 'localtime' feature.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I am very sorry, a typo snuck in in previous version

BTW. Kevin, when there is series of patches which are dependent on each other and create together a logical whole, it is recommended to provide cover letter for such "true series".

 gitweb/gitweb.perl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index b04ab8c..16abd4c 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4906,7 +4906,7 @@ sub git_log_body {
 		next if !%co;
 		my $commit = $co{'id'};
 		my $ref = format_ref_marker($refs, $commit);
-		my %ad = parse_date($co{'author_epoch'});
+		my %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});
 		git_print_header_div('commit',
 		               "<span class=\"age\">$co{'age_string'}</span>" .
 		               esc_html($co{'title'}) . $ref,
@@ -7064,7 +7064,7 @@ sub git_feed {
 	if (defined($commitlist[0])) {
 		%latest_commit = %{$commitlist[0]};
 		my $latest_epoch = $latest_commit{'committer_epoch'};
-		%latest_date   = parse_date($latest_epoch);
+		%latest_date   = parse_date($latest_epoch, $latest_commit{'comitter_tz'});
 		my $if_modified = $cgi->http('IF_MODIFIED_SINCE');
 		if (defined $if_modified) {
 			my $since;
@@ -7195,7 +7195,7 @@ XML
 		if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
 			last;
 		}
-		my %cd = parse_date($co{'author_epoch'});
+		my %cd = parse_date($co{'author_epoch'}, $co{'author_tz'});
 
 		# get list of changed files
 		open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,
-- 
1.7.3
Previous: Jakub NarebskiNext: Kevin Cernekee
Message 5 of 12 in “gitweb: rename parse_date() to format_date()”
  1. 1/3 gitweb: rename parse_date() to format_date()Kevin Cernekee, Mar 19, 2011
  2. 2/3 gitweb: introduce localtime featureKevin Cernekee, Mar 19, 2011
  3. 3/3 gitweb: change highlighting of "atnight" commitsKevin Cernekee, Mar 19, 2011
  4. 1/3 gitweb: Always call parse_date with timezone parameterJakub Narebski, Mar 19, 2011
  5. 1/3 gitweb: Always call parse_date with timezone parameterJakub Narebski, Mar 19, 2011
  6. Kevin CernekeeMar 19, 2011
  7. Jakub NarebskiMar 20, 2011
  8. Junio C HamanoMar 20, 2011
  9. 4/3 gitweb: Always call format_date with timezone parameterKevin Cernekee, Mar 20, 2011
  10. Jakub NarebskiMar 20, 2011
  11. Jakub NarebskiMar 20, 2011
  12. Kevin CernekeeMar 20, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.