Re: [PATCH] repack: find -> /usr/bin/find, as for cygwin

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Mar 19, 2011, 16:07 UTC
Message-ID: <20110319160754.GA5871@do>
In-Reply-To: <4D84D0C0.7080808@lsrfire.ath.cx>

On Sat, Mar 19, 2011 at 04:50:24PM +0100, René Scharfe wrote:

> Do we need to support pack files in subdirectories of $PACKDIR?  If
> not -- and I don't immediately see why, except that the current code
> does with its find call -- then the following patch might be a quick
> bandaid.  Untested, please be careful.

I looked at test-lib.sh but forgot git-sh-setup.sh, which does aliasing for find in MINGW build. With your patch, the last use of find is gone. So we might as well do this

diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index aa16b83..e891edc 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -232,9 +232,6 @@ case $(uname -s) in
 	sort () {
 		/usr/bin/sort "$@"
 	}
-	find () {
-		/usr/bin/find "$@"
-	}
 	is_absolute_path () {
 		case "$1" in
 		[/\\]* | [A-Za-z]:*)

-- 
Duy