Re: [PATCH 1/2] fetch-pack: Finish negotation if remote replies "ACK %s ready"

From: Jeff King <peff@peff.net>
Date: Mar 17, 2011, 07:16 UTC
Message-ID: <20110317071600.GG11931@sigill.intra.peff.net>
In-Reply-To: <20110317071512.GF11931@sigill.intra.peff.net>

On Thu, Mar 17, 2011 at 03:15:12AM -0400, Jeff King wrote:

Show 10 quoted lines

> > Assuming the client is only following the remote (and does not make
> > its own local commits), the client needs 11 rounds to spin through
> > the entire list of tags (32 commits per round, ceil(339/32) == 11).
> > Unfortunately the server knows on the first "have %s" line that
> > it can produce a good pack, and does not need to see the remaining
> > 320 tags in the other 10 rounds.
> 
> Does this optimization help in that case? From looking at the code, it
> seems that we offer "ACK %s ready" only in the case that the client
> has something we do not. I.e., they _are_ building local commits on top.

OK, never mind, I just read your 2/2. ;)

Sorry for the noise.

-Peff