[PATCH 1/8] enums: omit trailing comma for portability
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 16, 2011, 06:59 UTC
- Message-ID
- <20110316065910.GB5988@elie>
- In-Reply-To
- <20110316065256.GA5988@elie>
Since v1.7.2-rc0~23^2~2 (Add per-repository eol normalization, 2010-05-19), building with gcc -std=gnu89 -pedantic produces warnings like the following:
convert.c:21:11: warning: comma at end of enumerator list [-pedantic]
gcc is right to complain --- these commas are not permitted in C89. In the spirit of v1.7.2-rc0~32^2~16 (2010-05-14), remove them.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- At first, I was worried that the fixes from the series v1.7.2-rc0~32 had been in vain, but in reality it seems that there are only a few new C89-compatibility tweaks to make like this one.
cache.h | 2 +- convert.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cache.h b/cache.h index c4ef999..80f1236 100644 --- a/cache.h +++ b/cache.h @@ -585,7 +585,7 @@ extern enum safe_crlf safe_crlf; enum auto_crlf { AUTO_CRLF_FALSE = 0, AUTO_CRLF_TRUE = 1, - AUTO_CRLF_INPUT = -1, + AUTO_CRLF_INPUT = -1 }; extern enum auto_crlf auto_crlf; diff --git a/convert.c b/convert.c index d5aebed..7eb51b1 100644 --- a/convert.c +++ b/convert.c @@ -18,7 +18,7 @@ enum action { CRLF_TEXT, CRLF_INPUT, CRLF_CRLF, - CRLF_AUTO, + CRLF_AUTO }; struct text_stat {
-- 1.7.4.1