[PATCH] transport-helper.c: fix check for size_t < 0 v2
- From
Nicolas Kaiser <nikai@nikai.net>
- Date
- Mar 4, 2011, 23:16 UTC
- Message-ID
- <20110305001626.3b6c507d@absol.kitzblitz>
- In-Reply-To
- <AANLkTimc_iLDXxrV=tfZc+_dCkpx6897Lh8sZxkwbgDo@mail.gmail.com>
'bytes' is unsigned of type size_t, and can't be negative. But the assigned write() returns ssize_t, and -1 on error. For testing < 0, 'bytes' needs to be of a signed type.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- * Piotr Krukowiecki <piotr.krukowiecki@gmail.com>:
> You are right that, but the fix should be to use ssize_t not plain "int". > (udt_do_read() correctly uses ssize_t)
Indeed, thanks. Here's a version with ssize_t. Testsuite did not regress at my place.
transport-helper.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c index 4e4754c..ba06b70 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -973,7 +973,7 @@ static int udt_do_read(struct unidirectional_transfer *t) */ static int udt_do_write(struct unidirectional_transfer *t) { - size_t bytes; + ssize_t bytes; if (t->bufuse == 0) return 0; /* Nothing to write. */
-- 1.7.3.4