git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gitweb: cloud tags feature produces malformed XML for errors

From
Petr Baudis <pasky@suse.cz>
Date
Mar 3, 2011, 11:58 UTC
Message-ID
<20110303115856.GH24584@machine.or.cz>
In-Reply-To
<201103022218.46640.jnareb@gmail.com>
On Wed, Mar 02, 2011 at 10:18:44PM +0100, Jakub Narebski wrote:
Show 15 quoted lines
> Well, neither does README.html follow the repository when it is cloned,
> and usually neither does description ('description' file is generated by
> git default template, and description file overrides `gitweb.description'
> config variable).
> 
> Documentation always can be added, either as comments for the 'ctags'
> feature, or in gitweb/README (or, in the future, in gitweb manpage).
> 
> 
> What is most important that makes this feature to be considered for
> removal (or rehauling) is that only half of this feature is implemented
> in gitweb: the displaying part.  There is half-attempt of providing
> some web interface for managing tags... which needs external script with
> strict coupling, doesn't offer any access control as far as I know, do
> not allow deleting tags, etc.

Well, but your argument above also applies here - gitweb does not allow users to modify README.html or desrciption either. Who knows where ctags may come from, they might even be autogenerated based on something. I admit that the code could be a bit more resilient to invalid contents of the files, but I do not see that as a major problem either (it is possible to confuse gitweb by putting invalid stuff into other repository files too).

-- 
				Petr "Pasky" Baudis
Computer science education cannot make an expert programmer any more
than studying brushes and pigment can make an expert painter. --esr
Previous: Jonathan NiederNext: Jakub Narebski
Message 15 of 16 in “gitweb: cloud tags feature produces malformed XML for errors”
  1. Jonathan NiederMar 1, 2011
  2. Jakub NarebskiMar 2, 2011
  3. Jakub NarebskiMar 2, 2011
  4. Uwe Kleine-KönigMar 2, 2011
  5. J.H.Mar 2, 2011
  6. Jakub NarebskiMar 2, 2011
  7. Uwe Kleine-KönigMar 2, 2011
  8. Jakub NarebskiMar 3, 2011
  9. Uwe Kleine-KönigMar 3, 2011
  10. gitweb: Change the way "content tags" ('ctags') are handledJakub Narebski, Mar 7, 2011
  11. 2/1 gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo)Jakub Narebski, Mar 9, 2011
  12. Petr BaudisMar 9, 2011
  13. gitweb: do misparse nonnumeric content tag files that contain a digitJonathan Nieder, Jun 9, 2011
  14. Jonathan NiederJun 9, 2011
  15. Petr BaudisMar 3, 2011
  16. Jakub NarebskiMar 3, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.