git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-instaweb: Change how gitweb.psgi is made runnable as standalone app

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 26, 2011, 22:32 UTC
Message-ID
<20110226223142.5944.31865.stgit@localhost.localdomain>
According to blog post "FindBin, __FILE__, $0 and PSGI woes"
  http://bulknews.typepad.com/blog/2011/02/findbin-__file__-0-and-psgi-woes.html

by Tatsuhiko Miyagawa, using 'if (__FILE__ eq $0)' in .psgi code (to check if script was run from command line), is not supposed to work since Plack 0.9971.

Replace it with one of proposed solutions; while at it return $app explicitely, rather than implicitely by being a last expression.

This affects 'plackup' web server.
While at it cleanup whitespace.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 git-instaweb.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 10fcebb..86892f7 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -558,12 +558,14 @@ my \$app = builder {
 
 # make it runnable as standalone app,
 # like it would be run via 'plackup' utility
-if (__FILE__ eq \$0) {
+if (caller) {
+	return \$app;
+} else {
 	require Plack::Runner;
 
 	my \$runner = Plack::Runner->new();
 	\$runner->parse_options(qw(--env deployment --port $port),
-			       "$local" ? qw(--host 127.0.0.1) : ());
+	                        "$local" ? qw(--host 127.0.0.1) : ());
 	\$runner->run(\$app);
 }
 __END__
Next: Eric Wong
Message 1 of 2 in “git-instaweb: Change how gitweb.psgi is made runnable as standalone app”
  1. git-instaweb: Change how gitweb.psgi is made runnable as standalone appJakub Narebski, Feb 26, 2011
  2. Eric WongFeb 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.