Re: Git pack - repo size doubled

From: Jeff King <peff@peff.net>
Date: Feb 24, 2011, 08:31 UTC
Message-ID: <20110224083138.GA26439@sigill.intra.peff.net>
In-Reply-To: <ik549p$pq8$1@dough.gmane.org>

On Thu, Feb 24, 2011 at 09:19:06AM +0100, Maaartin wrote:

Show 8 quoted lines

> I'm using git version 1.7.3.3 under cygwin (W XP64). When I tried
> 
> git repack -A -d --depth=255 --window=255 --window-memory=4g
> 
> I've got the message
> 
> rm: cannot remove `pack-c75642be5314b1a98ddfcf0d51ac838db4af75ad.pack':
> Device or resource busy

Presumably some git process still has the pack open, and Windows can't delete open files. The process which removes the old pack is different from the one that creates the new pack, so there shouldn't be conflict there. Were you running any other git programs at the time?

> It seems like the file hadn't got closed. The non-deletion of the file
> roughly doubles the repo size (134070 KiB instead of 67470 KiB).
> 
> - Can I manually remove the file?

Probably. Move it (and its associated .idx file) out of the pack directory, and then run "git fsck" to make sure all is well.

> - If I do it, does "git fsck" suffice to make sure, everything's all right?

As a general rule, almost certainly, but there is one corner case. "git fsck" will proceed from your refs and reflogs and check that nothing is missing.

But it's possible that you had unreferenced objects in the old pack which will now be lost. In practice, this doesn't really matter much. Due to reflogs, things don't tend to be unreferenced. And even if they are, they are probably worthless old cruft that was expired from the reflog.

In your case, it is even more certain. Since you used "-A", unreachable objects in the original pack were exploded into loose objects. So assuming that process worked correctly, then everything in that pack is duplicated.

> - Would creating of multiple packs work better? What "--max-pack-size"
> would you recommend?

It shouldn't make a difference. This is about removing the old pack; it shouldn't matter how many new packs you've made, unless there is some bug.

-Peff