git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] bump rename limit defaults (again)

From
Jeff King <peff@peff.net>
Date
Feb 20, 2011, 10:10 UTC
Message-ID
<20110220101024.GC988@sigill.intra.peff.net>
In-Reply-To
<AANLkTim2ETC0T8=8D5pWstZRZ95eo5V0+Pr62mNXRBH1@mail.gmail.com>
On Sat, Feb 19, 2011 at 06:54:47PM +0100, Piotr Krukowiecki wrote:
Show 6 quoted lines
> On Sat, Feb 19, 2011 at 11:21 AM, Jeff King <peff@peff.net> wrote:
> > Let's bump the diff/merge default limits from 200/500 to
> > 400/1000. Those are 2 seconds and 10 seconds respectively on
> > my modern hardware.
> 
> Just curious - what is your modern hardware?

It's a Core i7 840QM. So it's a measly 1.8GHz, but it turboboosts up to 3.2GHz on a single-threaded process. The multiple cores are irrelevant for this timing, as it's very single-threaded[1].

The process used in the tens of megabytes of memory, so I think memory size is irrelevant. It was very CPU bound in my tests.

-Peff

[1] Actually, this is one place where multi-threading the algorithm would be very easy. It's literally an m*n double-loop, seeing which of each "n" sources matches each "m" destination best, and the expensive bit is comparing a source and dest. So you could parallelize score calculation up to m*n ways, then just sort the result for each dest.

Previous: Piotr KrukowieckiNext: Ævar Arnfjörð Bjarmason
Message 19 of 34 in “Merging limitations after directory renames -- interesting test repo”
  1. Martin LanghoffFeb 18, 2011
  2. Jeff KingFeb 18, 2011
  3. Linus TorvaldsFeb 18, 2011
  4. Linus TorvaldsFeb 19, 2011
  5. Junio C HamanoFeb 19, 2011
  6. Linus TorvaldsFeb 19, 2011
  7. Linus TorvaldsFeb 19, 2011
  8. Linus TorvaldsFeb 19, 2011
  9. Junio C HamanoFeb 19, 2011
  10. Jeff KingFeb 19, 2011
  11. Jeff KingFeb 19, 2011
  12. 1/4 merge: improve inexact rename limit warningJeff King, Feb 19, 2011
  13. Junio C HamanoFeb 21, 2011
  14. Jeff KingFeb 22, 2011
  15. Junio C HamanoFeb 22, 2011
  16. Jeff KingFeb 23, 2011
  17. 2/4 bump rename limit defaults (again)Jeff King, Feb 19, 2011
  18. Piotr KrukowieckiFeb 19, 2011
  19. Jeff KingFeb 20, 2011
  20. Ævar Arnfjörð BjarmasonFeb 19, 2011
  21. Jeff KingFeb 20, 2011
  22. 3/4 commit: stop setting rename limitJeff King, Feb 19, 2011
  23. 4/4 inexact rename detection eye candyJeff King, Feb 19, 2011
  24. Linus TorvaldsFeb 19, 2011
  25. Jeff KingFeb 20, 2011
  26. 1/3 add inexact rename detection progress infrastructureJeff King, Feb 20, 2011
  27. 2/3 merge: enable progress reporting for rename detectionJeff King, Feb 20, 2011
  28. 3/3 pull: propagate --progress to mergeJeff King, Feb 20, 2011
  29. Jeff KingFeb 20, 2011
  30. Martin LanghoffFeb 19, 2011
  31. Jeff KingFeb 20, 2011
  32. Martin LanghoffFeb 20, 2011
  33. Martin LanghoffFeb 19, 2011
  34. Martin LanghoffFeb 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.