Re: [PATCH 1/3] vcs-svn: Introduce svnload, a dumpfile producer

From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Feb 2, 2011, 02:53 UTC
Message-ID: <20110202025320.GB11339@kytes>
In-Reply-To: <AANLkTikUUojgj_H0r0L=XBi7H714xUvAS=vPsgMRNNjr@mail.gmail.com>

Hi Erik,

Erik Faye-Lund writes:

> A very superficial review, because I don't have much time, and don't
> know the surrounding code well. Sorry about that.

Thanks. I have to often switch back and fourth between GNU-style (for Subversion) and Linux-style (for Git), so please bear with my silly style errors.

Show 11 quoted lines

> On Tue, Feb 1, 2011 at 3:26 PM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> > +       if (!val) die("Malformed author line");
> > +       if (!(tz_off = strrchr(val, ' '))) goto error;
> > +       *tz_off++ = '\0';
> > +       if (!(t = strrchr(val, ' '))) goto error;
> 
> style: use
> "if (x)
> 	do_stuff();"
> instead of
> "if (x) do_stuff();"

This was intentional -- I'm only using it when do_stuff() is 'goto error'. I thought it looked nicer that way.

-- Ram