Re: [PATCH] tests: sanitize more git environment variables
- From
Jeff King <peff@peff.net>
- Date
- Jan 26, 2011, 20:34 UTC
- Message-ID
- <20110126203444.GB27478@sigill.intra.peff.net>
- In-Reply-To
- <20110126203331.GA27478@sigill.intra.peff.net>
On Wed, Jan 26, 2011 at 03:33:32PM -0500, Jeff King wrote:
Show 8 quoted lines
> These variables should generally not be set in one's > environment, but they do get set by rebase, which means > doing an interactive rebase like: > > pick abcd1234 foo > exec make test > > will cause false negatives in the test suite.
Or I guess false positives, depending on your definition of positive and negative. I.e., tests will fail when they shouldn't. :)
-Peff