Re: git notes and core.editor config

From: Johan Herland <johan@herland.net>
Date: Jan 11, 2011, 12:36 UTC
Message-ID: <201101111336.19466.johan@herland.net>
In-Reply-To: <AANLkTik-=s-F8dmBRLU8o9LcSztb1P0WnkN5HK_n_No4@mail.gmail.com>

On Tuesday 11 January 2011, Jeenu V wrote:

> On Tue, Jan 11, 2011 at 4:01 PM, Johan Herland <johan@herland.net>

wrote:

Show 19 quoted lines

> > On Tuesday 11 January 2011, Jeenu V wrote:
> >> My core.editor value in $HOME/.gitconfig is set to
> >>
> >>   [core]
> >>       editor = vi "+set tw=72 spell"
> >>
> >> so that I've text width of 72 with spell check turned on. I
> >> haven't found problems with any git commands that invoke editor,
> >> but notes. 'git notes' seems to invoke the vi for me with 3
> >> separate arguments instead of just one: "+set, tw=72, and spell".
> >> In other words, I don't think it honors shell quoting for editor
> >> config variable.
> >>
> >> Could this be a bug?
> >
> > What Git version are you running?
>
> $ git --version
> git version 1.7.0.4

Ah, there's your problem. In v1.7.1 "git notes" was builtin-ified (it used to be a shell script, but was reimplemented in C), so you're still running the shell script version of "git notes". I believe upgrading will solve your problem (as well as making "git notes" more featureful).

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net