Re: [PATCH] Fix wrong failures in config test

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2011, 17:29 UTC
Message-ID: <20110110172931.GB7882@burratino>
In-Reply-To: <4d2b3ecd.7c62abb5.bm000@wupperonline.de>

Ingo Brückl wrote:

> Jonathan Nieder wrote on Mon, 10 Jan 2011 10:52:51 -0600:

Show 6 quoted lines

>> How does output from "sh t1300-repo-config.sh -v -i" end?
>
>   expecting success: git config --rename-section branch.eins branch.zwei
>   fatal: No such section!
>   not ok - 50 rename section
>   #       git config --rename-section branch.eins branch.zwei

Thanks.

> The problem is that the last 'git config' worked on other-config due to
> variable GIT_CONFIG.

I'm still missing something.

	GIT_CONFIG=other-config git config -l > output
	echo $GIT_CONFIG

should result in no output to stdout, right? In other words, the construct

	envvar=value git command

is not supposed to pollute the current environment.

It sounds like you've checked that "unset GIT_CONFIG" fixes it; what's left is to explain why GIT_CONFIG had a value in the first place.

Confused, Jonathan