Re: [RFC PATCH v7 6/9] gitweb/lib - Simple output capture by redirecting STDOUT to file
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Dec 24, 2010, 09:49 UTC
- Message-ID
- <20101224094934.GA952@burratino>
- In-Reply-To
- <20101222235705.7998.76695.stgit@localhost.localdomain>
Jakub Narebski wrote:
> This patch was based on "gitweb: add output buffering and associated > functions" patch by John 'Warthog9' Hawley (J.H.) in "Gitweb caching v7" > series, and on code of Capture::Tiny by David Golden (Apache License 2.0).
Micronit: if the license of Capture::Tiny were relevant then we would be in trouble, I think. (Apache-2.0 and GPLv2 aren't compatible licenses.) Luckily
[...]
Show 10 quoted lines
> +# taken from Capture::Tiny by David Golden, Apache License 2.0
> +# with debugging stripped out
> +sub _relayer {
> + my ($fh, $layers) = @_;
> +
> + my %seen = ( unix => 1, perlio => 1); # filter these out
> + my @unique = grep { !$seen{$_}++ } @$layers;
> +
> + binmode($fh, join(":", ":raw", @unique));
> +}looks trivial enough. Maybe either avoiding mention of the license or clarifying that that is not intended to be the sole license for the stripped-down code would help?