git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] transport-helper: avoid dependency on thread-utils.h

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 10, 2010, 11:48 UTC
Message-ID
<20101210114839.GA5771@burratino>

Since the transport-helper does not use recursive mutexes or ask the number of cores, it does not require any declarations from the thread-utils lib. Removing the unnecessary #include avoids false positives from "make CHECK_HEADER_DEPENDENCIES=1".

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
The #include directive in question was added in 7851b1e60
(remote-fd/ext: finishing touches after code review, 2010-11-17),
at the same times as the necessary #include for <pthread.h>.
This patch seems to work for me, but I wouldn't be surprised if
to be missing something.
 transport-helper.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 3a50856..7c99051 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -11,7 +11,6 @@
 
 #ifndef NO_PTHREADS
 #include <pthread.h>
-#include "thread-utils.h"
 #endif
 
 static int debug;
-- 
1.7.2.4
Next: Junio C Hamano
Message 1 of 6 in “transport-helper: avoid dependency on thread-utils.h”
  1. transport-helper: avoid dependency on thread-utils.hJonathan Nieder, Dec 10, 2010
  2. Junio C HamanoDec 10, 2010
  3. 0/2 Re: transport-helper: avoid dependency on thread-utils.hJonathan Nieder, Dec 10, 2010
  4. 1/2 simplify inclusion of pthread.hJonathan Nieder, Dec 10, 2010
  5. Jonathan NiederDec 10, 2010
  6. 2/2 Makefile: transport-helper uses thread-utils.hJonathan Nieder, Dec 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.