Re: git format-patch should honor notes

From: Jeff King <peff@peff.net>
Date: Dec 7, 2010, 22:11 UTC
Message-ID: <20101207221151.GC1036@sigill.intra.peff.net>
In-Reply-To: <4CFEACC5.70005@redhat.com>

On Tue, Dec 07, 2010 at 02:53:09PM -0700, Eric Blake wrote:

Show 10 quoted lines

> My workflow is that I post patch series for upstream review via 'git
> send-email'.  Often, that results in feedback that requires me to
> amend/rebase my series, and post a v2 or v3 of the series.  By adding
> 'git config notes.rewriteRef refs/notes/commits', I can add notes that
> will carry across my rebase, and remind me what I changed in v2 (for
> example, git notes add -m 'v2: fix foo, per mail xyz@example.com').
> This is handy for me, and I think it is also handy for reviewers -
> someone who took the time to read through v1 should know what I changed
> in response to their comments, and only have to focus in on commits with
> changes, rather than on the entire resent series.

Yeah, that is a workflow that some others have mentioned using here, too. And I think there is general agreement that notes should go after the "---" in format-patch. We just need a working patch.

Thomas posted one in February:

  http://article.gmane.org/gmane.comp.version-control.git/140819

But there were some issues and it never got polished. Michael suggested that he does something similar here:

  http://article.gmane.org/gmane.comp.version-control.git/140819

but there was no indication on whether it happens manually or if he has a patch. I don't know if anything else has happened in that area. I'm sure if you feel like working on a patch it would be well received.

-Peff