Re: [PATCH] logging branch deletion to help recovering from mistakes

From: Jeff King <peff@peff.net>
Date: Dec 7, 2010, 18:39 UTC
Message-ID: <20101207183930.GA27340@sigill.intra.peff.net>
In-Reply-To: <20101207183739.GB3725@spearce.org>

On Tue, Dec 07, 2010 at 10:37:39AM -0800, Shawn O. Pearce wrote:

Show 6 quoted lines

> Yes, you are right.  We should instead let the normal reflog expire
> action do its work here, and delete the empty log file when it is
> finally empty.
> 
> I guess we also need repack and prune to enumerate these deleted
> reflogs and retain the objects their records point to.

Definitely. I sort of assumed all of those things just traversed .git/logs blindly without regard to whether there was a ref, which would handle this automagically. But maybe that is not the case.

Is there a reason to require that each log is specifically tied to a ref?

-Peff