Re: [PATCH] git-rm.txt: Fix quoting

From: Jeff King <peff@peff.net>
Date: Dec 7, 2010, 17:25 UTC
Message-ID: <20101207172542.GA25827@sigill.intra.peff.net>
In-Reply-To: <20101207171939.GA21105@burratino>

On Tue, Dec 07, 2010 at 11:19:39AM -0600, Jonathan Nieder wrote:

Show 14 quoted lines

> Michael J Gruber wrote:
> 
> > --- a/Documentation/git-rm.txt
> > +++ b/Documentation/git-rm.txt
> > @@ -111,8 +111,8 @@ tree using this command:
> >  git ls-files -z | xargs -0 rm -f
> >  ----------------
> >  
> > -and then "untar" the new code in the working tree. Alternately
> > -you could "rsync" the changes into the working tree.
> > +and then `untar` the new code in the working tree. Alternately
> > +you could `rsync` the changes into the working tree.
> 
> I like the patch.  Is there really an "untar" command?

Heh. Yeah, I was so caught up in looking at formatting that I didn't think about the actual meaning. :) Untar should definitely not be a literal (and should not have been quoted in the first place).

> Maybe something like this on top?  ('rsync' is in italics because it
> is just a command name rather than a full command ready to be typed on
> the command line.)

No opinion on that from me.

>  Using ``git commit -a''
> -~~~~~~~~~~~~~~~~~~~~~
> +~~~~~~~~~~~~~~~~~~~~~~~

I think this length doesn't have to match the text above, but I agree it looks better to viewers of the source if it does.

-Peff