Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Dec 6, 2010, 19:23 UTC
- Message-ID
- <20101206192326.GA12383@dcvr.yhbt.net>
- In-Reply-To
- <4CFA27E0.8070308@web.de>
Torsten Bögershausen <tboegi@web.de> wrote:
Show 7 quoted lines
> Commit df73af5f66 is does not let the test case fail, > when Compress::Zlib is missing. > But: > On a MacOS X 10.6 system with missing Compress::Zlib > using svn version 1.6.5 (r38866) the gz file is created. > Solution: > Check for the existance of the unhandled.log.gz file.
I wonder if your system could have multiple perl installations and git-svn is calling one while the shell scripts are calling another. I'm not sure if there is another way the gz file could be created while Compress::Zlib is missing.
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Torsten Bögershausen wrote in <4CFA27DD.7030105@web.de>:
> Now we do not depend on internal implementation details of svn. > And the code is 3% easier to understand :-)
I agree on this point completely
Acked-by: Eric Wong <normalperson@yhbt.net>
Show 17 quoted lines
> --- > t/t9143-git-svn-gc.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh > index 337ea59..8a95d78 100755 > --- a/t/t9143-git-svn-gc.sh > +++ b/t/t9143-git-svn-gc.sh > @@ -37,7 +37,7 @@ test_expect_success 'git svn gc runs' 'git svn gc' > test_expect_success 'git svn index removed' '! test -f > .git/svn/refs/remotes/git-svn/index' > -if perl -MCompress::Zlib -e 0 2>/dev/null > +if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz > then > test_expect_success 'git svn gc produces a valid gzip file' ' > gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz > --