Re: [PATCH 04/14] msvc: Fix macro redefinition warnings

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 4, 2010, 21:04 UTC
Message-ID: <201012042204.52002.j6t@kdbg.org>
In-Reply-To: <4CFA8FE3.1050009@ramsay1.demon.co.uk>

On Samstag, 4. Dezember 2010, Ramsay Jones wrote:

Show 7 quoted lines

> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -14,12 +14,6 @@ typedef int socklen_t;
>  #define S_ISLNK(x) (((x) & S_IFMT) == S_IFLNK)
>  #define S_ISSOCK(x) 0
>
> -#ifndef _STAT_H_

Instead of removing the macros, wouldn't we be much safer with just

#ifndef S_IWUSR

? I suggest S_IWUSR because it is used inside #ifdef WIN32 brackets in test-chmtime.c and seems to be more important than the others :-)

Show 8 quoted lines

> -#define S_IRUSR 0
> -#define S_IWUSR 0
> -#define S_IXUSR 0
> -#define S_IRWXU (S_IRUSR | S_IWUSR | S_IXUSR)
> -#endif
>  #define S_IRGRP 0
>  #define S_IWGRP 0
>  #define S_IXGRP 0

-- Hannes