git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 4, 2010, 20:52 UTC
Message-ID
<20101204205206.GB3170@burratino>
In-Reply-To
<4CFA92A2.4030801@ramsay1.demon.co.uk>
Ramsay Jones wrote:
Show 8 quoted lines
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -149,7 +149,7 @@ static void wt_status_print_change_data(struct wt_status *s,
>  {
>  	struct wt_status_change_data *d = it->util;
>  	const char *c = color(change_type, s);
> -	int status = status;
> +	int status = 0;
Just for the record (I assume you are already aware of this):
 http://thread.gmane.org/gmane.comp.version-control.git/133278/focus=133422
 http://thread.gmane.org/gmane.comp.version-control.git/124676/focus=124803

I personally feel lukewarm about this kind of change. Is it possible to suppress this warning from msvc?

Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 8 in “wt-status.c: Initialise variable to suppress msvc warning”
  1. 14/14 wt-status.c: Initialise variable to suppress msvc warningRamsay Jones, Dec 4, 2010
  2. Jonathan NiederDec 4, 2010
  3. Ramsay JonesDec 9, 2010
  4. Junio C HamanoDec 9, 2010
  5. Erik Faye-LundDec 9, 2010
  6. Sebastian SchuberthDec 10, 2010
  7. Erik Faye-LundDec 10, 2010
  8. Sebastian SchuberthDec 10, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.