Re: [PATCH 3/4] fast-import: let importers retrieve blobs

From: Thomas Rast <trast@student.ethz.ch>
Date: Dec 4, 2010, 13:24 UTC
Message-ID: <201012041424.33146.trast@student.ethz.ch>
In-Reply-To: <201012031130.06008.trast@student.ethz.ch>

Thomas Rast wrote:

Show 9 quoted lines

> Jonathan Nieder wrote:
> > +test_expect_success PIPE 'R: copy using cat-file' '
> [...]
> > +	dd if=/dev/stdin of=blob bs=$size count=1 <&3 &&
> 
> This breaks my automated tester, though I am not sure exactly why.  It
> runs RHEL5, and I have
> 
>   lrwxrwxrwx 1 root root 15 Sep  1 09:25 /dev/stdin -> /proc/self/fd/0

Ah, answering my own question: on my normal box, strace'ing dd[1] in such an invocation uses

  open("/dev/stdin", O_RDONLY)            = 3
  dup2(3, 0)                              = 0
  close(3)                                = 0

OTOH on RHEL5[2] it tries a different order:

  close(0)                                = 0
  open("/dev/stdin", O_RDONLY)            = -1 ENOENT (No such file or directory)

Oops.

[1] dd --version says: dd (coreutils) 7.1 [2] dd (coreutils) 5.97

-- 
Thomas Rast
trast@{inf,student}.ethz.ch