git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/10] parse-options: make resuming easier after PARSE_OPT_STOP_AT_NON_OPTION

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Dec 1, 2010, 23:32 UTC
Message-ID
<20101201233255.GI31815@burratino>
In-Reply-To
<20101201232728.GA31815@burratino>

Introduce a PARSE_OPT_NON_OPTION state, so parse_option_step() callers can easily distinguish between non-options and other reasons for option parsing termination (like "--").

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 parse-options.c |    3 ++-
 parse-options.h |    1 +
 2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/parse-options.c b/parse-options.c
index 4c58e7f..4b000e6 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -369,7 +369,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx,
 			if (parse_nodash_opt(ctx, arg, options) == 0)
 				continue;
 			if (ctx->flags & PARSE_OPT_STOP_AT_NON_OPTION)
-				break;
+				return PARSE_OPT_NON_OPTION;
 			ctx->out[ctx->cpidx++] = ctx->argv[0];
 			continue;
 		}
@@ -451,6 +451,7 @@ int parse_options(int argc, const char **argv, const char *prefix,
 	switch (parse_options_step(&ctx, options, usagestr)) {
 	case PARSE_OPT_HELP:
 		exit(129);
+	case PARSE_OPT_NON_OPTION:
 	case PARSE_OPT_DONE:
 		break;
 	default: /* PARSE_OPT_UNKNOWN */
diff --git a/parse-options.h b/parse-options.h
index ab1bdf0..b897d6b 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -167,6 +167,7 @@ extern NORETURN void usage_msg_opt(const char *msg,
 enum {
 	PARSE_OPT_HELP = -1,
 	PARSE_OPT_DONE,
+	PARSE_OPT_NON_OPTION,
 	PARSE_OPT_UNKNOWN
 };
 
-- 
1.7.2.3
Previous: Jonathan NiederNext: Jonathan Nieder
Message 19 of 21 in “update-index: migrate to parse-options API”
  1. 00/10 update-index: migrate to parse-options APIJonathan Nieder, Dec 1, 2010
  2. 01/10 parse-options: Don't call parse_options_check() so muchJonathan Nieder, Dec 1, 2010
  3. René ScharfeDec 5, 2010
  4. Stephen BoydDec 6, 2010
  5. 02/10 parse-options: clearer reporting of API misuseJonathan Nieder, Dec 1, 2010
  6. Jonathan NiederDec 2, 2010
  7. 02/10 parse-options: clearer reporting of API misuseJonathan Nieder, Dec 2, 2010
  8. 02/10 parse-options: clearer reporting of API misuseJonathan Nieder, Dec 2, 2010
  9. 03/10 parse-options: move NODASH sanity checks to parse_options_checkJonathan Nieder, Dec 1, 2010
  10. 03/10 parse-options: move NODASH sanity checks to parse_options_checkJonathan Nieder, Dec 2, 2010
  11. 04/10 parse-options: sanity check PARSE_OPT_NOARG flagJonathan Nieder, Dec 1, 2010
  12. 04/10 parse-options: sanity check PARSE_OPT_NOARG flagJonathan Nieder, Dec 2, 2010
  13. 05/10 parse-options: do not infer PARSE_OPT_NOARG from option typeJonathan Nieder, Dec 1, 2010
  14. 06/10 parse-options: never suppress arghelp if LITERAL_ARGHELP is setJonathan Nieder, Dec 1, 2010
  15. Stephen BoydDec 3, 2010
  16. Jonathan NiederDec 3, 2010
  17. Stephen BoydDec 3, 2010
  18. 07/10 parse-options: allow git commands to invent new option typesJonathan Nieder, Dec 1, 2010
  19. 08/10 parse-options: make resuming easier after PARSE_OPT_STOP_AT_NON_OPTIONJonathan Nieder, Dec 1, 2010
  20. 09/10 setup: save prefix (original cwd relative to toplevel) in startup_infoJonathan Nieder, Dec 1, 2010
  21. 10/10 update-index: migrate to parse-options APIJonathan Nieder, Dec 1, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.