git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fallback on _NSGetExecutablePath to get the executable path if using argv[0] fails

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 29, 2010, 17:12 UTC
Message-ID
<20101129171211.GL8037@burratino>
In-Reply-To
<AANLkTimwRJqje1-HhzKj-L-5-2CvhTC0+Pr0Cvj7d_kc@mail.gmail.com>
Thiago Farina wrote:
> On Mon, Nov 29, 2010 at 2:57 PM, Jeremy Huddleston <jeremyhu@apple.com> wrote:
>> Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
>> Reviewed-by: Matt Wright <mww@apple.com>

I like the idea, but could you add a short commit message explaining the existing behavior and what improvement this makes?

> Why not #if defined(__APPLE__), like above?

More importantly, please search for #ifdef in existing code to get some examples of how we like to do platform-specific things.

The section "2) #ifdefs are ugly" of linux-2.6/Documentation/SubmittingPatches explains the rationale.

Regards, Jonathan

Previous: Thiago FarinaNext: Jeremy Huddleston
Message 3 of 14 in “Fallback on _NSGetExecutablePath to get the executable path if using argv[0] fails”
  1. Fallback on _NSGetExecutablePath to get the executable path if using argv[0] failsJeremy Huddleston, Nov 29, 2010
  2. Thiago FarinaNov 29, 2010
  3. Jonathan NiederNov 29, 2010
  4. Fallback on _NSGetExecutablePath to get the executable path if using argv[0] failsJeremy Huddleston, Nov 29, 2010
  5. Jonathan NiederNov 29, 2010
  6. Junio C HamanoNov 29, 2010
  7. Jeremy HuddlestonNov 29, 2010
  8. Jeremy HuddlestonNov 29, 2010
  9. Jonathan NiederNov 29, 2010
  10. Jeremy HuddlestonNov 29, 2010
  11. Jonathan NiederNov 29, 2010
  12. Kevin BallardNov 29, 2010
  13. Jonathan NiederDec 3, 2010
  14. Kevin BallardDec 3, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.