Re: [PATCH] entry.c: remove "checkout-index" from error messages

From: Jeff King <peff@peff.net>
Date: Nov 28, 2010, 06:30 UTC
Message-ID: <20101128063046.GA2902@sigill.intra.peff.net>
In-Reply-To: <1290918998-15208-1-git-send-email-pclouds@gmail.com>

On Sun, Nov 28, 2010 at 11:36:38AM +0700, Nguyễn Thái Ngọc Duy wrote:

Show 13 quoted lines

> Back then when entry.c was part of checkout-index (or checkout-cache
> at that time [1]). It makes sense to print the command name in error
> messages. Nowadays entry.c is in libgit and can be used by any
> commands, printing "git checkout-index: blah" does no more than
> confusion. The error messages without it still give enough information.
> 
> [1] 12dccc1 (Make fiel checkout function available to the git library - 2005-06-05)
> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  I attempted to replace "git checkout-index" with the actual command name
>  when these functions are called, but I think it's better just removing
>  it...

Agreed. This came up recently in another thread[1], and I also tracked it down to a simple cut-and-paste from the original checkout-index.

Acked-by: Jeff King <peff@peff.net>

-Peff

[1] http://article.gmane.org/gmane.comp.version-control.git/160751