Re: [PATCH v8 1/5] Introduce bulk-move detection in diffcore.
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 25, 2010, 15:02 UTC
- Message-ID
- <20101125150218.GA16049@burratino>
- In-Reply-To
- <AANLkTi=Ekoe+RSrRFj63S___Vsa5kTsDKJVPamFsz0c2@mail.gmail.com>
Ævar Arnfjörð Bjarmason wrote:
> On Fri, Oct 29, 2010 at 00:08, Yann Dirson <ydirson@altern.org> wrote:
Show 6 quoted lines
>> + slash = memrchr(src, '/', len); > > I can't compile pu now on Solaris due to this bit. Are you planning on > picking up the patch / configure / Makefile detection discussed in the > "[PATCH] compat: add memrchr()" thread? Just wondering what the > progress was on that.
BTW, remember that the configure / Makefile detection is only an extra nicety. [1] teaches git to rely on the system memrchr on glibc systems only; on other systems (unless they define memrchr as a macro, which would be a strange thing to do), gitmemrchr is used.
Upshot: it should be safe to use [1] without the configure / Makefile support. Later, an interested person can write a patch for improved memrchr[2] on *BSD and Plan 9.
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/159081/focus=159121 [2] Lower code size. Maybe faster.