Re: [PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 22, 2010, 17:00 UTC
- Message-ID
- <20101122170040.GA2084@burratino>
- In-Reply-To
- <1290429109-2318-1-git-send-email-ospite@studenti.unina.it>
Hi,
Antonio Ospite wrote:
Show 14 quoted lines
> --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -261,10 +262,10 @@ test_expect_success $PREREQ 'Author From: in message body' ' > test_expect_success $PREREQ 'Author From: in message body' ' > clean_fake_sendmail && > git send-email \ > --from="Example <nobody@example.com>" \ > --to=nobody@example.com \ > --smtp-server="$(pwd)/fake.sendmail" \ > $patches && > - sed "1,/^\$/d" < msgtxt1 > msgbody1 > + sed "1,/^\$/d" < msgtxt1 > msgbody1 && > grep "From: A <author@example.com>" msgbody1 > '
[...]
> $patches && > - sed "1,/^\$/d" < msgtxt1 > msgbody1 > + sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
[...]
> @@ -300,5 +300,5 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' ' > $patches \ > - 2>errors > + 2>errors &&
Good.
Show 6 quoted lines
> @@ -574,7 +574,7 @@ EOF > " > > test_expect_success $PREREQ '--suppress-cc=sob' ' > - git config --unset sendemail.cccmd > + git config --unset sendemail.cccmd &&
This one needs a test_might_fail in front, since "git config --unset" would fail if some future change causes the configuration item not to be set in the first place.
Thanks.