git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 0/15] svn-fe: support for property deltas (but not text deltas yet)

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 20, 2010, 00:45 UTC
Message-ID
<20101120004525.GA17445@burratino>
In-Reply-To
<20101118050023.GA14861@burratino>
Hi,
Jonathan Nieder wrote:
> This mini-series is part of an effort to get David and Ram's svn
> import work integrated into mainline git[1].

Another chapter. This one is mostly David's work. One can test it (I haven't tried) by taking out the safety

	die("text deltas not supported");

and letting it import from some real-world deltified dump file, treating deltas as the full text. Then one can validate as usual, by checking the modes of files in each revision of the imported tree.

I've done a little refactoring to more easily understand the patch, but the heart of the work is still David's. Any bugs and infelicities are probably mine (especially the evil hack to support switching between executables and symlinks).

Especially useful would be a nicer set of tests. A tool to create dump files based on a more concise description would make this and some future tasks a lot easier (hint, hint).

Thoughts? Improvements? Any of these ready to go? I can rearrange to put the uncontroversial patches at the beginning once it is clear what those are.

David Barr (1):
  vcs-svn: Implement Prop-delta handling
Jonathan Nieder (14):
  vcs-svn: Check for errors from open()
  vcs-svn: Eliminate node_ctx.srcRev global
  vcs-svn: Eliminate node_ctx.mark global
  vcs-svn: Unclutter handle_node by introducing have_props var
  vcs-svn: Use mark to indicate nodes with text
  vcs-svn: handle_node: Handle deletion case early
  vcs-svn: Replace = Delete + Add
  vcs-svn: Merge repo_replace and repo_modify functions
  vcs-svn: Delay read of per-path properties
  vcs-svn: Reject path nodes without Node-action
  vcs-svn: More dump format sanity checks
  vcs-svn: Make source easier to read on small screens
  vcs-svn: Split off function for handling of individual properties
  vcs-svn: Sharpen parsing of property lines
 contrib/svn-fe/svn-fe.c |    3 +-
 t/t9010-svn-fe.sh       |  301 ++++++++++++++++++++++++++++++++++++++++++++++-
 test-svn-fe.c           |    3 +-
 vcs-svn/repo_tree.c     |   21 +--
 vcs-svn/repo_tree.h     |    3 +-
 vcs-svn/svndump.c       |  191 +++++++++++++++++++-----------
 vcs-svn/svndump.h       |    2 +-
 7 files changed, 436 insertions(+), 88 deletions(-)
-- 
1.7.2.3
Previous: Jonathan NiederNext: Jonathan Nieder
Message 4 of 40 in “svn-fe: recognize v3 dumps”
  1. 0/2 svn-fe: recognize v3 dumpsJonathan Nieder, Nov 18, 2010
  2. 1/2 vcs-svn: Error out for v3 dumpsJonathan Nieder, Nov 18, 2010
  3. 2/2 vcs-svn: Allow simple v3 dumps (no deltas yet)Jonathan Nieder, Nov 18, 2010
  4. 0/15 svn-fe: support for property deltas (but not text deltas yet)Jonathan Nieder, Nov 20, 2010
  5. 01/15 vcs-svn: Check for errors from open()Jonathan Nieder, Nov 20, 2010
  6. 02/15 vcs-svn: Eliminate node_ctx.srcRev globalJonathan Nieder, Nov 20, 2010
  7. 03/15 vcs-svn: Eliminate node_ctx.mark globalJonathan Nieder, Nov 20, 2010
  8. 04/15 vcs-svn: Unclutter handle_node by introducing have_props varJonathan Nieder, Nov 20, 2010
  9. 05/15 vcs-svn: Use mark to indicate nodes with included textJonathan Nieder, Nov 20, 2010
  10. 06/15 vcs-svn: handle_node: Handle deletion case earlyJonathan Nieder, Nov 20, 2010
  11. 07/15 vcs-svn: Replace = Delete + AddJonathan Nieder, Nov 20, 2010
  12. 08/15 vcs-svn: Combine repo_replace and repo_modify functionsJonathan Nieder, Nov 20, 2010
  13. 09/15 vcs-svn: Delay read of per-path propertiesJonathan Nieder, Nov 20, 2010
  14. 10/15 vcs-svn: Reject path nodes without Node-actionJonathan Nieder, Nov 20, 2010
  15. Jonathan NiederNov 20, 2010
  16. 11/15 vcs-svn: More dump format sanity checksJonathan Nieder, Nov 20, 2010
  17. Jonathan NiederNov 30, 2010
  18. 0/2 intermittent repo_tree corruptionJonathan Nieder, Dec 5, 2010
  19. 1/2 treap: make treap_insert return inserted nodeJonathan Nieder, Dec 5, 2010
  20. vcs-svn: Allow change nodes for root of tree (/)Jonathan Nieder, Dec 6, 2010
  21. Jonathan NiederDec 6, 2010
  22. 12/15 vcs-svn: Make source easier to read on small screensJonathan Nieder, Nov 20, 2010
  23. 13/15 vcs-svn: Split off function for handling of individual propertiesJonathan Nieder, Nov 20, 2010
  24. 14/15 vcs-svn: Sharpen parsing of property linesJonathan Nieder, Nov 20, 2010
  25. 15/15 vcs-svn: Implement Prop-delta handlingJonathan Nieder, Nov 20, 2010
  26. 0/8 svn-fe: support for text deltasJonathan Nieder, Nov 20, 2010
  27. 1/8 svn-fe: Prepare for strbuf useJonathan Nieder, Nov 20, 2010
  28. 2/8 vcs-svn: Internal fast_export_save_blob helperJonathan Nieder, Nov 20, 2010
  29. 3/8 vcs-svn: Introduce repo_read_path to check the content at a pathJonathan Nieder, Nov 20, 2010
  30. Jonathan NiederMar 6, 2011
  31. 4/8 vcs-svn: Introduce fd_buffer routinesJonathan Nieder, Nov 20, 2010
  32. 5/8 vcs-svn: Read delta preimage from file descriptorJonathan Nieder, Nov 20, 2010
  33. 6/8 vcs-svn: Let caller set up sliding window for delta preimageJonathan Nieder, Nov 20, 2010
  34. Jonathan NiederNov 20, 2010
  35. 7/8 vcs-svn: Teach line_buffer about temporary filesJonathan Nieder, Nov 20, 2010
  36. 8/8 vcs-svn: Implement text-delta handlingJonathan Nieder, Nov 20, 2010
  37. 10/8 vcs-svn: Consume whole preimage when applying deltasJonathan Nieder, Dec 4, 2010
  38. 9/8 svn-fe: Test script for handling of dumps with --deltasJonathan Nieder, Nov 20, 2010
  39. Jonathan NiederDec 4, 2010
  40. 2/2 vcs-svn: fix intermittent repo_tree corruptionJonathan Nieder, Dec 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.