git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: cherry-pick -x formats the message incorrectly

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 16, 2010, 21:34 UTC
Message-ID
<20101116213400.GA28402@burratino>
In-Reply-To
<20101116193504.GB15828@burratino>
Jonathan Nieder wrote:
Show 13 quoted lines
> Junio C Hamano wrote:
>> Martin Svensson <martin.k.svensson@netinsight.se> writes:
>
>>> It should be:
>>>
>>>   foo
>>>   
>>>   (cherry picked from commit eb42a6475d2c2e4fff7a1b626ce6e27eec21e886)
>>>
>>> Am I right?
>>
>> I tend to agree (modulo s/summary/subject/ would be the wording I would
>> have used).
[...]
Show 6 quoted lines
> Mm, I use it and do not agree; I think the rule should rather be:
> 
>  - if there is a Signed-off chain, quietly integrate into that (no added
>    newline)
> 
>  - if there is not a Signed-off chain, add the extra newline.

Hmm, probably it is obvious, but I sent this reply to the wrong message. Sorry for the nonsense.

Martin, I do agree with you and would be happy to see cherry-pick -x respecting the

	One-line subject
	Possibly multi-line, detailed description.
	Signed-off-by: chain
format.
Previous: Jonathan Nieder
Message 4 of 4 in “cherry-pick -x formats the message incorrectly”
  1. Martin SvenssonNov 16, 2010
  2. Junio C HamanoNov 16, 2010
  3. Jonathan NiederNov 16, 2010
  4. Jonathan NiederNov 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.