Re: [PATCHv6 06/23] notes.h/c: Propagate combine_notes_fn return value to add_note() and beyond

From: Johan Herland <johan@herland.net>
Date: Nov 14, 2010, 23:50 UTC
Message-ID: <201011150050.27131.johan@herland.net>
In-Reply-To: <20101114212243.GC10150@burratino>

On Sunday 14 November 2010, Jonathan Nieder wrote:

Show 20 quoted lines

> Thiago Farina wrote:
> > On Tue, Nov 9, 2010 at 7:49 PM, Johan Herland <johan@herland.net> wrote:
> >>               die("confused: combine_notes_overwrite failed");
> > 
> > This message looks like more a debug information. Could it be
> > rewritten to be more user friendly / more informative?
> 
> Sverre mentioned the same thing.  The intent is the same as the existing
> 
> 		die("should not happen, someone must be hit on the forehead");
> 
> --- i.e., to provoke bug reports if it happens, without the appearance
> of begging. :)
> 
> So how about:
> 
> 		die("BUG: combine_notes_overwrite failed");
> 
> Something involving assert() could also work, but that tends to be
> a bit ugly.

Agreed. I've rewritten the die() messages in the following v6.1 patches.

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net