Re: is it kosher for pre-commit to change what's staged?

From: Joey Hess <joey@kitenet.net>
Date: Nov 11, 2010, 20:46 UTC
Message-ID: <20101111204626.GA13937@gnu.kitenet.net>
In-Reply-To: <20101111192648.GE30870@efreet.light.src>

Jan Hudec wrote:

Show 6 quoted lines

> The problem point is not big files, but whether they can change the file mode
> associated with the entry, since in this case the tree contains a file, but
> index should contain a symlink. Looking at the documentation, there does not
> seem to be a way to do it.
> 
> It might be worth adding support for it now we have a use-case.

I suppose that if I were using smudge filters, I'd probably not need to use symlinks at all. I'll think about it.

It belatedly occured to me that I already had something else modifying the index in pre-commit, and smudge filters cannot handle its use case.

That is, etckeeper (http://kitenet.net/~joey/code/etckeeper). The pre-commit script there stores some metadata about files that git usually doesn't track, by putting it in a dotfile, and stages that dotfile for commit. Which currently works fine, except for the minor problem that the user doesn't see the dotfile listed in the commit message.

-- 
see shy jo