Re: [PATCH] gitweb: Time::HiRes is in core for Perl 5.8

From: Jakub Narebski <jnareb@gmail.com>
Date: Nov 11, 2010, 19:01 UTC
Message-ID: <201011112001.50202.jnareb@gmail.com>
In-Reply-To: <7vwrojhjiz.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

Show 8 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > Therefore there is no need to check if it is installed.  We can also
> > import gettimeofday and tv_interval.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> 
> I think "... and 'use 5.008' is at the begining of the script already, "

because gitweb requires Perl 5.8, in order to have good Unicode support.

> is missing before that "Therefore".  But otherwise it is a reasonable
> thing to do.
> 
> Thanks.

Would you amend commit message when applying it, then?

-- 
Jakub Narebski
Poland