Re: [PATCH] gitk: improve dark background support

From: David Fries <david@fries.net>
Date: Nov 11, 2010, 04:59 UTC
Message-ID: <20101111045918.GA7572@spacedout.fries.net>
In-Reply-To: <20101108131412.GE22067@login.drsnuggles.stderr.nl>

On Mon, Nov 08, 2010 at 02:14:12PM +0100, Matthijs Kooijman wrote:

Show 16 quoted lines

> Hi David,
> 
> I've been using gitk with a gray-on-black color-scheme for a while now,
> so I've given your patch a test drive. It seems to work as expected and
> indeed makes gitk a bit more pleasant to use with a dark color scheme.
> 
> I've reviewed the code a bit and it looks ok as well (though I'm hardly
> familiar with git internals, and not at all in this area).
> 
> I did encounter one minor issue, though: If you change the foreground
> color, the current view is not updated until you restart or switch views
> (or otherwise trigger a redraw, I guess). A quick look at the code shows
> that the "setfg" function contains some code that updates all canvases
> and all contexts in $fglist with the new fg color. I guess that
> something similar should be done for these tag colors to get them
> updated right away (though perhaps that should be a second patch)?

After much work and document searching I now know more about tk/tcl than ever before and have figured out how to make the colors dynamically update when the preferences change. Have a look if you will, and if it looks good I'll post it to the maintainer for inclusion. I'm also posting a new patch series to the list.

branch gitk_colors git://gitorious.org/~dfries/git/dfriess-git-mainline.git

and the more disorganized work in progress branch is gitk_colors_PreSquash

> A final note: There are still some other problems with working with
> grey-on-black color scheme. In case your interested in working on those,
> I've listed them at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=568470

Anything left in that list worth going over? In terms of the .gitk config colors what are you using and what isn't working?

my relevant .gitk config file settings, set mainfont {Helvetica 8} set textfont {Courier 8} set uifont {Helvetica 9 bold} set uicolor grey85 set bgcolor black set fgcolor white set colors {green red blue magenta darkgrey brown orange} set diffcolors {red green cyan} set markbgcolor #404060 set selectbgcolor gray50

-- 
David Fries <david@fries.net>
http://fries.net/~david/ (PGP encryption key available)