When is a patch ready for inclusion? (Re: [PATCH] Documentation/git-pull: clarify configuration)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 10, 2010, 17:25 UTC
Message-ID: <20101110172543.GC11513@burratino>
In-Reply-To: <AANLkTik5MMKWune_i6omu=vXmuVEJqff6Bm0=yNcS9+z@mail.gmail.com>

(cc-ing the list because it seems likely the wording could be improved)

Hi Martin,

Martin von Zweigbergk wrote:

> I don't want to spam Junio, so I'm asking you instead. I sent my first
> version of the patch to Junio as well. In SubmittingPatches, it says
> "[...] the maintainer (gitster@pobox.com) if (and only if) the patch
> is ready for inclusion". How do I know if it's ready for inclusion?

I think that bit is not too important. The idea (and it isn't spelled out) is that you should Cc Junio if:

 - you need Junio's advice because it is his area of expertise, or
 - Junio has already been discussing the patch with you, or
 - it is urgent that the patch be applied

and you probably should not Cc Junio if:

 - the patch is unpolished and covers a subject that is not his
   interest (e.g., something in contrib/)

>                                                               Or is the
> "ready for inclusion" just about my perception of my patches?

Yes. Hopefully this would make it easier to spot which patches are ready for his attention and which need more discussion first. See [1] and [2].

Hope that helps, Jonathan

[1] http://thread.gmane.org/gmane.comp.version-control.git/72432/focus=72442 [2] http://thread.gmane.org/gmane.comp.version-control.git/144199/focus=144506