git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] CodingGuidelines: add a note to help contributors catch some errors earlier.

From
YDYann Dirson <ydirson@free.fr>
Date
Oct 23, 2010, 18:48 UTC
Message-ID
<20101023184830.GQ4983@home.lan>
In-Reply-To
<AANLkTikCr5yRHzetY9-T=_rg+PZM-e8ZnQvL79ucws+6@mail.gmail.com>
On Sat, Oct 23, 2010 at 03:11:19PM -0200, Thiago Farina wrote:
Show 8 quoted lines
> On Sat, Oct 23, 2010 at 12:17 PM, Yann Dirson <ydirson@altern.org> wrote:
> > + - C code is expected to compile when the build is launched with the
> > +   following command:
> > +
> > +   make CFLAGS="-Wall -Wdeclaration-after-statement -Werror"
> 
> Why this is not in the Makefile by default? Also -Wall is already in
> the Makefile.

CFLAGS seems to be used for more than gcc, and -Wall seems to be portable enough to be overriden only in a couple of cases. It would not be the same for those flags.

Also note that -Wdeclaration-after-statement is also mentionned in SubmittingPatches, but I still think it is a better place in CodingGuidelines, which contributers are most likely to use as a checklist before publishing.

Previous: Thiago Farina
Message 3 of 3 in “CodingGuidelines: add a note to help contributors catch some errors earlier.”
  1. CodingGuidelines: add a note to help contributors catch some errors earlier.Yann Dirson, Oct 23, 2010
  2. Thiago FarinaOct 23, 2010
  3. Yann DirsonOct 23, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.