Re: [PATCH] diff: don't presume empty file when corresponding object is missing
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Oct 22, 2010, 07:04 UTC
- Message-ID
- <20101022070446.GA19834@pengutronix.de>
- In-Reply-To
- <alpine.LFD.2.00.1010212353550.2764@xanadu.home>
Hi Nicolas,
On Fri, Oct 22, 2010 at 12:02:27AM -0400, Nicolas Pitre wrote:
Show 5 quoted lines
> The low-level diff code will happily produce totally bogus diff output > with a broken repository via format-patch and friends by treating missing > objects as empty files. Let's prevent that from happening any longer. > > Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Great, this fixes format-patch to fail in my tree as advertised. Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |